lewismc commented on issue #151: ANY23-445 Review spotbugs issues URL: https://github.com/apache/any23/pull/151#issuecomment-542985803 Current branch results in following errors ``` [INFO] --- spotbugs-maven-plugin:3.1.12.2:check (default-cli) @ apache-any23-api --- [INFO] BugInstance size is 2 [INFO] Error size is 0 [INFO] Total bugs: 2 [ERROR] org.apache.any23.mime.MIMEType defines compareTo(MIMEType) and uses Object.equals() [org.apache.any23.mime.MIMEType] At MIMEType.java:[line 134] EQ_COMPARETO_USE_OBJECT_EQUALS [ERROR] Possible null pointer dereference in org.apache.any23.plugin.Any23PluginManager.loadJARDir(File) due to return value of called method [org.apache.any23.plugin.Any23PluginManager, org.apache.any23.plugin.Any23PluginManager] Dereferenced at Any23PluginManager.java:[line 201]Known null at Any23PluginManager.java:[line 201] NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE ``` @HansBrende if you get a chance can you review. You can run spotbugs analysis as follows ``` mvn spotbugs:check ``` You can also get detailed information by running ``` mvn clean install -DskipTests && mvn spotbugs:gui ``` You can then load the file in ./api/target/spotbugsXml.xml
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
