Whoops. The disclaimer isn't needed any longer as we are now TLP and the verification instructions need to be updated.
PR anyone? Thanks, Thomas On Sat, May 21, 2016 at 10:49 PM, York, Brennon <[email protected] > wrote: > +0 (binding) > > OSX 10.11.4 > java version "1.8.0_60" > > Verifying Sig: apache-apex-malhar-3.4.0-source-release.tar.gz > PASSED; GOODSIG, VALIDSIG > Verifying Sig: apache-apex-malhar-3.4.0-source-release.zip > PASSED; GOODSIG, VALIDSIG > Checking digest: apache-apex-malhar-3.4.0-source-release.tar.gz > SHA: PASSED; Match > MD5: PASSED; Match > Checking digest: apache-apex-malhar-3.4.0-source-release.zip > SHA: PASSED; Match > MD5: PASSED; Match > > Expanding: apache-apex-malhar-3.4.0-source-release.tar.gz > Checking for necessary files: > DISCLAIMER: FAILED; Not found > LICENSE: PASSED; Found > NOTICE: PASSED; Found > README.md: PASSED; Found > CHANGELOG.md: PASSED; Found > RAT Check: PASSED > Compilation: PASSED > Tests: PASSED > > Expanding: apache-apex-malhar-3.4.0-source-release.zip > Checking for necessary files: > DISCLAIMER: FAILED; Not found > LICENSE: PASSED; Found > NOTICE: PASSED; Found > README.md: PASSED; Found > CHANGELOG.md: PASSED; Found > RAT Check: PASSED > Compilation: PASSED > Tests: PASSED > > > I¹m only a +0 because, as Apache Apex documentation states [1], we require > a DISCLAIMER file which doesn¹t exist in either the .zip or .tar.gz files. > That said I don¹t see it as critical to the release and something we can > ensure is in the next release. Other than that looks great! > > [1] http://apex.apache.org/verification.html > > On 5/21/16, 9:28 PM, "Justin Mclean" <[email protected]> wrote: > > >Hi, > > > >+1 (binding) > > > >I checked: > >- signatures and hashes good > >- LICENSE and NOTICE correct > >- All source files have Apache headers > >- No unexpected binary files > >- Can compile from source > >- Tests pass (on OSX) > > > >Thanks, > >Justin > > > > > > ________________________________________________________ > > The information contained in this e-mail is confidential and/or > proprietary to Capital One and/or its affiliates and may only be used > solely in performance of work or services for Capital One. The information > transmitted herewith is intended only for use by the individual or entity > to which it is addressed. If the reader of this message is not the intended > recipient, you are hereby notified that any review, retransmission, > dissemination, distribution, copying or other use of, or taking of any > action in reliance upon this information is strictly prohibited. If you > have received this communication in error, please contact the sender and > delete the material from your computer. > >
