[ 
https://issues.apache.org/jira/browse/APEXMALHAR-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310852#comment-15310852
 ] 

ASF GitHub Bot commented on APEXMALHAR-2103:
--------------------------------------------

Github user DT-Priyanka commented on a diff in the pull request:

    
https://github.com/apache/incubator-apex-malhar/pull/300#discussion_r65418317
  
    --- Diff: 
library/src/test/java/com/datatorrent/lib/io/fs/FileSplitterInputTest.java ---
    @@ -155,6 +155,38 @@ public void testFileMetadata() throws 
InterruptedException
       }
     
       @Test
    +  public void testFileMetadataForSingleFile() throws InterruptedException
    --- End diff --
    
    there is already a test with name "testSingleFile" can we rename this to 
something like, "testScannerFilterForDuplicates"


> scanner issues in FileSplitterInput class
> -----------------------------------------
>
>                 Key: APEXMALHAR-2103
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2103
>             Project: Apache Apex Malhar
>          Issue Type: Bug
>            Reporter: Chaitanya
>            Assignee: Chaitanya
>
> Issue: FileSplitter continuously emitting filemetadata even though there is  
> a single file.
> Observation: For the same file, While updating and accessing the 
> referenceTimes map in FIleSplitterInput and TimeBasedScanner, the Keys are 
> different. Because of this, the oldestTimeModification is always null in 
> TimeBasedScanner.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to