[
https://issues.apache.org/jira/browse/APEXCORE-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310893#comment-15310893
]
ASF GitHub Bot commented on APEXCORE-463:
-----------------------------------------
Github user siyuanh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/338#discussion_r65421945
--- Diff: engine/src/main/java/com/datatorrent/stram/webapp/TypeGraph.java
---
@@ -355,7 +356,8 @@ public int size()
}
Set<String> result = new TreeSet<>();
for (TypeGraphVertex node : tgv.allInstantiableDescendants) {
- if ((isAncestor(InputOperator.class.getName(), node.typeName) ||
!getAllInputPorts(node).isEmpty())) {
+ if ((isAncestor(InputOperator.class.getName(), node.typeName) ||
isAncestor(Module.class.getName(), node.typeName)
--- End diff --
Method should do what the name suggest . Should either change the name of
the method or have this in a separate method. There are same problem in
TypeGraph and OperatorDiscover, please fix them as well. Otherwise, it would be
confusing and error-prone in the future.
> get-app-package-operators in ApexCLI not listing certain modules
> -----------------------------------------------------------------
>
> Key: APEXCORE-463
> URL: https://issues.apache.org/jira/browse/APEXCORE-463
> Project: Apache Apex Core
> Issue Type: Bug
> Reporter: shubham pathak
> Assignee: shubham pathak
>
> FSInputModule is not being shown in output of get-app-package-operators
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
