Github user brennonyork commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/316#discussion_r66519279
--- Diff:
library/src/main/java/com/datatorrent/lib/window/TriggerOption.java ---
@@ -0,0 +1,55 @@
+package com.datatorrent.lib.window;
+
+import java.util.LinkedList;
+import java.util.List;
+
+/**
+ *
+ */
+public class TriggerOption
+{
+
+ public static enum WatermarkOpt
+ {
+ BEFORE,
+ AFTER
+ }
+
+ WatermarkOpt watermarkOpt = WatermarkOpt.BEFORE;
+
+ private List<Object[]> size = new LinkedList<>();
+
+ public static class TriggerOptionBuilder
+ {
+
+ public static TriggerOption every(long quantity, Quantification.Unit
unit)
--- End diff --
can we get a comment here to explain what `quantity` and `unit` mean. a
simple example like the example code below would be good, but should be with
this code for people developing on this later to quickly understand.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
