[ 
https://issues.apache.org/jira/browse/APEXMALHAR-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15325222#comment-15325222
 ] 

ASF GitHub Bot commented on APEXMALHAR-2111:
--------------------------------------------

Github user chinmaykolhatkar commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/311#discussion_r66675231
  
    --- Diff: 
library/src/main/java/com/datatorrent/lib/projection/ProjectionOperator.java ---
    @@ -308,5 +303,45 @@ private void handleProjection(Object t)
         }
       }
     
    +  /**
    +   * set selectFields, a list of fields to be selected from incoming POJO
    +   *
    +   * @param selectFields List of fields from POJO to be selected
    +   */
    +  public void setSelectFields(List<String> selectFields)
    --- End diff --
    
    Now that we have proper configuration for selectFields, can you please add 
@useSchema and @description javadoc metatag. You can refer to POJOEnricher 
setIncludeFields setter method for this.


> Projection Operator config params shall use List instead of comma-separated 
> field names
> ---------------------------------------------------------------------------------------
>
>                 Key: APEXMALHAR-2111
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2111
>             Project: Apache Apex Malhar
>          Issue Type: Improvement
>            Reporter: Pradeep A. Dalvi
>            Assignee: Pradeep A. Dalvi
>
> Projection Operator accepts 2 config params: selectFields & dropFields. 
> Currently both these parameters accept values in comma-separated field names 
> format. However this is not inline with other operators do to accept multiple 
> values, for which they use List instead.
> So this proposal is to make change in Projection Operator to accept config 
> params as List instead of comma-separated string. Hence selectFields & 
> dropFields shall accept List going forward.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to