Github user siyuanh commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/321#discussion_r67779698
--- Diff:
kafka/src/main/java/org/apache/apex/malhar/kafka/KafkaConsumerWrapper.java ---
@@ -74,7 +75,7 @@
private static final Logger logger =
LoggerFactory.getLogger(KafkaConsumerWrapper.class);
- private boolean isAlive = false;
--- End diff --
The stop method cannot guarantee immediate stop either unless you
synchronize the stop method with the while block in the separate thread. Here
as long as there is no concurrent data write operation, I think it should be
fine
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
