[ 
https://issues.apache.org/jira/browse/APEXMALHAR-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342652#comment-15342652
 ] 

ASF GitHub Bot commented on APEXMALHAR-2121:
--------------------------------------------

Github user siyuanh commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/323#discussion_r67949068
  
    --- Diff: 
contrib/src/main/java/com/datatorrent/contrib/kafka/AbstractKafkaInputOperator.java
 ---
    @@ -203,6 +204,14 @@ public AbstractKafkaInputOperator()
        */
       protected abstract void emitTuple(Message message);
    --- End diff --
    
    That's why I'm asking can we do that. It does have compatibility issue but 
on the other hand if some one wants to emit the tuple along with partition id 
etc, he/she is forced to implement the emitTuple method as well. Well, we can 
keep it as it is now. @DT-Priyanka can you file a jira to make this change in 
0.9 kafka input operator.  We can change the existing interface for that one    


> KafkaInputOperator emitTuple method should be able to emit more than just 
> message
> ---------------------------------------------------------------------------------
>
>                 Key: APEXMALHAR-2121
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2121
>             Project: Apache Apex Malhar
>          Issue Type: Improvement
>            Reporter: Priyanka Gugale
>            Assignee: Priyanka Gugale
>            Priority: Minor
>
> AbstractKafkaInputOperator in malhar-contrib operator had emitTuple method 
> with parameter as "Message". User can't extend this method to access more 
> kafka parameters other than messages.
> We should have a method to access to "KafkaMessage" so that user can choose 
> from multiple fields which he/she wants to emit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to