Github user vrozov commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/329#discussion_r69063970
--- Diff:
library/src/main/java/com/datatorrent/lib/io/fs/FileSplitterInput.java ---
@@ -318,6 +317,9 @@ public TimeBasedDirectoryScanner()
@Override
public void setup(Context.OperatorContext context)
{
+ if (scanService == null) {
--- End diff --
why is it necessary to check for null? Under what condition it will be not
null? As far as I know platform calls setup/terminate once per deployment. IMO,
it is safer to create new execution service each time setup is called and
possibly assert or throw RuntimeException if scanService is not null to avoid
misusage in unit tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
