Hi Pramod Very useful document. Some questions/comments from me (sorry for any newbie comments):
- for the "Update an Existing Operator" section, are there any backward compatibility constraints one should be aware of? - it will be very useful to have each guideline illustrated by an actual example (e.g. an example of combining 2 or more operators in a module, initialization and teardown cases in constructor/setup/beginWindow/endWindow/deactivate/teardown etc) - should the guidelines say something about unit tests and how unit tests should typically be written for operators (also include other kinds of automated tests in-case "unit" testing is difficult) - didn't find any references to WindowedOperator anywhere (but did find WindowedStream). Will be good to have hyperlinks for all references - java 1.8/1.7 compatibility requirement? - with respect to "...only the data for the first input port..." , how is "first" input port determined? On Tue, Jul 5, 2016 at 11:23 AM, Pramod Immaneni <[email protected]> wrote: > I received some feedback. Any other comments before adding these guidelines > to the project. > > Thanks > > On Fri, Jun 17, 2016 at 3:12 PM, Pramod Immaneni <[email protected]> > wrote: > > > Hi everyone, > > > > I wanted to create a set of guidelines that would help folks that want to > > contribute to Malhar. The goal is that by following these guidelines the > > contributions will be assured a certain level of quality as the different > > aspects to consider, common missteps and mistakes will be taken care of > > which in turn would also make the review process smoother by reducing the > > number of review iterations before the contribution gets merged. I tried > to > > capture as much information as I thought would help developers towards > this > > goal based on past experience and exposure, in a document. > > > > Please go through it and provide your feedback, it will be greatly > > appreciated. I will go through your comments and incorporate any > necessary > > changes. After that I hope this document will become a living document as > > part of the contribution guidelines and evolve with the times. > > > > > > > https://drive.google.com/open?id=1WjbaIogVtMDQwbvxTlQxrFqUbK9D75bk98asW9e5OxA > > > > Thanks > > >
