[
https://issues.apache.org/jira/browse/APEXMALHAR-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15365376#comment-15365376
]
ASF GitHub Bot commented on APEXMALHAR-2069:
--------------------------------------------
Github user sanjaypujare commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/333#discussion_r69834329
--- Diff:
library/src/test/java/com/datatorrent/lib/io/fs/FileSplitterInputTest.java ---
@@ -499,7 +499,7 @@ public void testRecoveryOfBlockMetadataIterator()
throws InterruptedException
testMeta.fileSplitterInput.getScanner().setScanIntervalMillis(500);
- testMeta.fileSplitterInput.setup(testMeta.context);
--- End diff --
For the first point, we can (should) add another unit test just to test
FileSplitterInput.setup() which in any case sounds like a better idea.
The 2nd point is not very clear. Are you saying there are many other
instances of non-transient fields which should be checked for null in setup()
or are you saying there are many fields which should ideally be declared
transient?
> FileSplitterInput and TimeBasedDirectoryScanner - move operational fields
> initialization from constructor to setup
> ------------------------------------------------------------------------------------------------------------------
>
> Key: APEXMALHAR-2069
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2069
> Project: Apache Apex Malhar
> Issue Type: Improvement
> Reporter: Vlad Rozov
> Assignee: Sanjay M Pujare
> Fix For: 3.5.0
>
>
> For example, there is no need for scanService to be initialized in the
> constructor. It should be done during operator setup().
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
