[jira] [Commented] (APEXMALHAR-1701) Deduper : create a deduper backed by Managed State

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/APEXMALHAR-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374623#comment-15374623
 ] 

ASF GitHub Bot commented on APEXMALHAR-1701:
--------------------------------------------

Github user chinmaykolhatkar commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/335#discussion_r70587509
  
    --- Diff: 
library/src/main/java/org/apache/apex/malhar/lib/dedup/AbstractDeduper.java ---
    @@ -0,0 +1,463 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.apex.malhar.lib.dedup;
    +
    +import java.util.Iterator;
    +import java.util.Map;
    +import java.util.Map.Entry;
    +import java.util.concurrent.ExecutionException;
    +import java.util.concurrent.Future;
    +
    +import javax.validation.constraints.NotNull;
    +
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import org.apache.apex.malhar.lib.state.BucketedState;
    +import 
org.apache.apex.malhar.lib.state.managed.ManagedTimeUnifiedStateImpl;
    +import org.apache.apex.malhar.lib.state.managed.TimeBucketAssigner;
    +import org.apache.hadoop.classification.InterfaceStability.Evolving;
    +
    +import com.google.common.base.Preconditions;
    +import com.google.common.collect.Maps;
    +import com.google.common.util.concurrent.Futures;
    +
    +import com.datatorrent.api.AutoMetric;
    +import com.datatorrent.api.Context;
    +import com.datatorrent.api.Context.OperatorContext;
    +import com.datatorrent.api.DAG;
    +import com.datatorrent.api.DefaultInputPort;
    +import com.datatorrent.api.DefaultOutputPort;
    +import com.datatorrent.api.Operator;
    +import com.datatorrent.api.Operator.ActivationListener;
    +import com.datatorrent.api.annotation.OperatorAnnotation;
    +import com.datatorrent.api.annotation.OutputPortFieldAnnotation;
    +import com.datatorrent.lib.fileaccess.FileAccessFSImpl;
    +import com.datatorrent.lib.fileaccess.TFileImpl;
    +import com.datatorrent.netlet.util.Slice;
    +
    +/**
    + * Abstract class which allows de-duplicating incoming tuples based on a 
configured key.
    + * Also supports expiry mechanism based on a configurable expiry period 
configured using {@link TimeBucketAssigner}
    + * in {@link ManagedTimeUnifiedStateImpl}
    + *
    + * @param <T> type of events
    + */
    +@Evolving
    +@OperatorAnnotation(checkpointableWithinAppWindow = false)
    +public abstract class AbstractDeduper<T>
    +    implements Operator, Operator.IdleTimeHandler, 
ActivationListener<Context>, Operator.CheckpointNotificationListener
    +{
    +  /**
    +   * The input port on which events are received.
    +   */
    +  public final transient DefaultInputPort<T> input = new 
DefaultInputPort<T>()
    +  {
    +    @Override
    +    public final void process(T tuple)
    +    {
    +      processTuple(tuple);
    +    }
    +  };
    +
    +  /**
    +   * The output port on which deduped events are emitted.
    +   */
    +  public final transient DefaultOutputPort<T> output = new 
DefaultOutputPort<T>();
    +
    +  /**
    +   * The output port on which duplicate events are emitted.
    +   */
    +  @OutputPortFieldAnnotation(optional = true)
    +  public final transient DefaultOutputPort<T> duplicates = new 
DefaultOutputPort<T>();
    +
    +  /**
    +   * The output port on which expired events are emitted.
    +   */
    +  @OutputPortFieldAnnotation(optional = true)
    +  public final transient DefaultOutputPort<T> expired = new 
DefaultOutputPort<T>();
    +
    +  /**
    +   * Whether or not the order of tuples be maintained
    +   */
    +  protected boolean orderedOutput = false;
    +
    +  @NotNull
    +  protected final ManagedTimeUnifiedStateImpl managedState = new 
ManagedTimeUnifiedStateImpl();
    --- End diff --
    
    Here the new value is assigned and made @NotNull... I don't think this make 
sense.. What is the purpose of @NotNull here?


> Deduper : create a deduper backed by Managed State
> --------------------------------------------------
>
>                 Key: APEXMALHAR-1701
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-1701
>             Project: Apache Apex Malhar
>          Issue Type: Task
>          Components: algorithms
>            Reporter: Chandni Singh
>            Assignee: Chandni Singh
>
> Need a de-deduplicator operator that is based on Managed State.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)