[
https://issues.apache.org/jira/browse/APEXCORE-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376026#comment-15376026
]
ASF GitHub Bot commented on APEXCORE-488:
-----------------------------------------
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/357#discussion_r70728942
--- Diff:
engine/src/main/java/com/datatorrent/stram/StreamingAppMasterService.java ---
@@ -614,7 +615,16 @@ protected void serviceStart() throws Exception
}
WebApp webApp = WebApps.$for("stram", StramAppContext.class,
appContext, "ws").with(config).start(new StramWebApp(this.dnmgr));
LOG.info("Started web service at port: " + webApp.port());
- this.appMasterTrackingUrl =
NetUtils.getConnectAddress(webApp.getListenerAddress()).getHostName() + ":" +
webApp.port();
+ String host =
NetUtils.getConnectAddress(webApp.getListenerAddress()).getHostName() + ":" +
webApp.port();
+
+ // For backward compatibility, not adding scheme in TrackingURL for
non-HTTPS
+ // TODO: Remove the check in next major release and add scheme always
+ if (ConfigUtils.isSSLEnabled(config)) {
+ String scheme = ConfigUtils.getSchemePrefix(config);
--- End diff --
why do you need to make `ConfigUtils.getSchemePrefix` call? If
`ConfigUtils.isSSLEnabled == true` then scheme is always https://..
Why not have `this.appMasterTrackingUrl =
ConfigUtils.getSchemePrefix(config) + host` instead of `if-else` loop?
> Issues in SSL communication with StrAM
> --------------------------------------
>
> Key: APEXCORE-488
> URL: https://issues.apache.org/jira/browse/APEXCORE-488
> Project: Apache Apex Core
> Issue Type: Bug
> Reporter: Pradeep A. Dalvi
> Assignee: Pradeep A. Dalvi
>
> Couple of issues in SSL communication with StrAM to track application progress
> - trackingURL without protocol scheme, makes YARN to pick up default HTTP.
> This happens even if the yarn.http.policy is set to HTTPS_ONLY.
> - StramAgent assumes always HTTP communication
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
