Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/360#discussion_r71920532
--- Diff:
engine/src/main/java/com/datatorrent/stram/client/ConfigPackage.java ---
@@ -37,10 +37,13 @@
import org.apache.commons.io.FileUtils;
import org.apache.commons.lang3.StringUtils;
+import org.apache.hadoop.conf.Configuration;
import net.lingala.zip4j.core.ZipFile;
import net.lingala.zip4j.exception.ZipException;
+import static
com.datatorrent.stram.client.StramClientUtils.jsonFileToAppInfo;
--- End diff --
jsonFileToAppInfo is only used in one place. We should probably just use
StramClientUtils.jsonFileToAppInfo, instead of import static here, to be
consistent with the rest of StramClientUtils calls.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
