[ 
https://issues.apache.org/jira/browse/APEXCORE-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15390186#comment-15390186
 ] 

ASF GitHub Bot commented on APEXCORE-494:
-----------------------------------------

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/359#discussion_r71945201
  
    --- Diff: 
engine/src/main/java/com/datatorrent/stram/plan/physical/PhysicalPlan.java ---
    @@ -895,8 +895,10 @@ private void redoPartitions(PMapping currentMapping, 
String note)
             addedPartitions.add(newPartition);
           } else {
             // check whether mapping was changed
    +        int currentPartitionsSize = mainPC.currentPartitions.size();
             for (DefaultPartition<Operator> pi : mainPC.currentPartitions) {
    -          if (pi == newPartition && pi.isModified()) {
    +          if (pi == newPartition && (pi.isModified() ||
    --- End diff --
    
    @siyuanh A1->B1->C1 and A2->B2->C2 don't need to be redeployed assuming 
that they continue to handle the same set of keys. In your example, if S emits 
keys 1 and 2 and at some point starts to emit 1, 2 and 3 it is necessary to 
deploy A3->B3->C3 and redeploy U and Aggregator, while A1->B1->C1 and 
A2->B2->C2 don't need to be redeployed. In case, S starts to emit 1, 2, 3 and 4 
and both 1 and 4 are routed to A1, A1->B1->C1 needs to be redeployed as it's 
key set changes.


> Window id of downstream operator is not moving after dynamic partition of 
> upstream operator.
> --------------------------------------------------------------------------------------------
>
>                 Key: APEXCORE-494
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-494
>             Project: Apache Apex Core
>          Issue Type: Bug
>            Reporter: Chaitanya
>            Assignee: Chaitanya
>         Attachments: PhysicalDAGAfterKafkaRepartition.png, 
> PhysicalDAGBeforeKafkaRepartition.png, 
> PhysicalOperatorAfterKafkaRepartition.png
>
>
> Created the following application to reproduce this issue.
> Application has the following DAG:
>    KafkaSinglePortStringInputOperator(Input) -> ConsoleOutputOperator(Output)
>    
>    I launched the application with below configuration:
> Kafka topic created with single partition and replication factor as 1.
> Partition Strategy: ONE_TO_ONE
>    Launched the application successfully. After some time, I increased the 
> topic partitions to 2. After re-partition, the window of down stream operator 
> is not moving. By looking into the app Physical DAG, it looks like there is 
> an issue in construction of Physical DAG after re-partition.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to