[ 
https://issues.apache.org/jira/browse/APEXMALHAR-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391748#comment-15391748
 ] 

ASF GitHub Bot commented on APEXMALHAR-2157:
--------------------------------------------

Github user shubham-pathak22 commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/348#discussion_r72048793
  
    --- Diff: 
library/src/main/java/com/datatorrent/lib/formatter/Formatter.java ---
    @@ -48,6 +49,13 @@
     {
       protected transient Class<?> clazz;
     
    +  @AutoMetric
    +  protected long errorTupleCount;
    --- End diff --
    
    Those need to be private. Have made it private and added protected  methods 
to access the values. 


> Improvements in JSON Formatter
> ------------------------------
>
>                 Key: APEXMALHAR-2157
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2157
>             Project: Apache Apex Malhar
>          Issue Type: Improvement
>            Reporter: shubham pathak
>            Assignee: shubham pathak
>            Priority: Minor
>
> We need following features in existing JSON Formatter
> 1. Ability to provide date format for different date fields in POJO. Current 
> implementation accepts just one format and applies the same to all date 
> fields.
> 2. Ability to provide JSON field to POJO field mapping.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to