Github user PramodSSImmaneni commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/347#discussion_r73001911
  
    --- Diff: library/src/main/java/com/datatorrent/lib/io/jms/JMSBase.java ---
    @@ -143,7 +172,7 @@ public void setConnectionFactoryProperties(Map<String, 
String> connectionFactory
       @Deprecated
       public void setUser(String user)
    --- End diff --
    
    Another option is to provide the connectionFactoryClass helper for now and 
take up deprecation discussions after these changes are included. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to