Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/364#discussion_r73449937
  
    --- Diff: 
engine/src/main/java/com/datatorrent/stram/engine/StreamingContainer.java ---
    @@ -902,14 +902,14 @@ private void deployNodes(List<OperatorDeployInfo> 
nodeList) throws IOException
     
           Context parentContext;
           if (ndi instanceof UnifierDeployInfo) {
    -        OperatorContext unifiedOperatorContext = new OperatorContext(0, 
((UnifierDeployInfo)ndi).operatorAttributes, containerContext);
    +        OperatorContext unifiedOperatorContext = new OperatorContext(ndi, 
containerContext);
             parentContext = new 
PortContext(ndi.inputs.get(0).contextAttributes, unifiedOperatorContext);
             massageUnifierDeployInfo(ndi);
           } else {
             parentContext = containerContext;
           }
     
    -      OperatorContext ctx = new OperatorContext(ndi.id, 
ndi.contextAttributes, parentContext);
    +      OperatorContext ctx = new OperatorContext(ndi, parentContext);
    --- End diff --
    
    @chandnisingh Here `ndi` may also be an instance of `UnifierDeployInfo` in 
which case, the new code will use `ndi.operatorAttribute` while the old code 
was using `ndi.contextAttributes`. It sounds that currently only `id` and 
`name` can be copied from OperatorDeployInfo to OperatorContext, while 
attributes must be passed in the constructor. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to