[
https://issues.apache.org/jira/browse/APEXMALHAR-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410588#comment-15410588
]
ASF GitHub Bot commented on APEXMALHAR-2156:
--------------------------------------------
Github user PramodSSImmaneni commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/347#discussion_r73784544
--- Diff: library/src/main/java/com/datatorrent/lib/io/jms/JMSBase.java ---
@@ -76,18 +79,59 @@
private transient Session session;
private transient Destination destination;
- private String connectionFactoryClass;
- private Map<String, String> connectionFactoryProperties =
Maps.newHashMap();
+ @NotNull
+ private ConnectionFactoryBuilder connectionFactoryBuilder = new
DefaultConnectionFactoryBuilder();
private String ackMode = "CLIENT_ACKNOWLEDGE";
- private String clientId = "TestClient";
- private String subject = "TEST.FOO";
+ private String clientId;
+ private String subject;
private int batch = 10;
private int messageSize = 255;
private boolean durable = false;
private boolean topic = false;
private boolean verbose = false;
protected boolean transacted = true;
+ public static interface ConnectionFactoryBuilder
+ {
--- End diff --
Looks good
> JMS Input operator enhancements
> -------------------------------
>
> Key: APEXMALHAR-2156
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2156
> Project: Apache Apex Malhar
> Issue Type: Improvement
> Reporter: Sanjay M Pujare
> Assignee: Sanjay M Pujare
> Original Estimate: 672h
> Remaining Estimate: 672h
>
> This is described in
> https://drive.google.com/open?id=1gapzjxTiePP0VwaOrc-FWfw4xNK6bcIuxkNkGKoZAiA
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
