Github user PramodSSImmaneni commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/347#discussion_r73784652
--- Diff: library/src/main/java/com/datatorrent/lib/io/jms/JMSBase.java ---
@@ -76,18 +79,59 @@
private transient Session session;
private transient Destination destination;
- private String connectionFactoryClass;
- private Map<String, String> connectionFactoryProperties =
Maps.newHashMap();
+ @NotNull
+ private ConnectionFactoryBuilder connectionFactoryBuilder = new
DefaultConnectionFactoryBuilder();
private String ackMode = "CLIENT_ACKNOWLEDGE";
- private String clientId = "TestClient";
- private String subject = "TEST.FOO";
+ private String clientId;
+ private String subject;
private int batch = 10;
private int messageSize = 255;
private boolean durable = false;
private boolean topic = false;
private boolean verbose = false;
protected boolean transacted = true;
+ public static interface ConnectionFactoryBuilder
+ {
+ public ConnectionFactory buildConnectionFactory();
+ }
+
+ public static class DefaultConnectionFactoryBuilder implements
ConnectionFactoryBuilder
+ {
+ protected Map<String, String> connectionFactoryProperties =
Maps.newHashMap();
--- End diff --
NotNull validation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
