[
https://issues.apache.org/jira/browse/APEXMALHAR-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15413166#comment-15413166
]
ASF GitHub Bot commented on APEXMALHAR-2172:
--------------------------------------------
Github user bhupeshchawda commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/358#discussion_r74015328
--- Diff:
library/src/test/java/com/datatorrent/lib/db/jdbc/JdbcPojoPollableOpeartorTest.java
---
@@ -0,0 +1,251 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package com.datatorrent.lib.db.jdbc;
+
+import java.io.File;
+import java.io.IOException;
+import java.sql.Date;
+import java.util.Collection;
+import java.util.Iterator;
+import java.util.List;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.ScheduledFuture;
+import java.util.concurrent.TimeUnit;
+
+import org.junit.After;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+
+import org.apache.apex.malhar.lib.wal.WindowDataManager;
+import org.apache.commons.io.FileUtils;
+import org.apache.commons.lang3.tuple.MutablePair;
+
+import com.google.common.collect.Lists;
+
+import com.datatorrent.api.Attribute;
+import com.datatorrent.api.Context;
+import com.datatorrent.api.DAG;
+import com.datatorrent.api.DefaultPartition;
+import com.datatorrent.api.Partitioner;
+import com.datatorrent.lib.helper.OperatorContextTestHelper;
+import com.datatorrent.lib.helper.TestPortContext;
+import com.datatorrent.lib.testbench.CollectorTestSink;
+import com.datatorrent.lib.util.FieldInfo;
+import com.datatorrent.lib.util.KeyValPair;
+import com.datatorrent.lib.util.TestUtils;
+
+import static org.mockito.Matchers.any;
+import static org.mockito.Matchers.anyLong;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+public class JdbcPojoPollableOpeartorTest extends JdbcOperatorTest
+{
+ public String dir = null;
+ @Mock
+ private ScheduledExecutorService mockschedular;
+ @Mock
+ private ScheduledFuture futureTaskMock;
+ @Mock
+ private WindowDataManager windowDataManagerMock;
+
+ @Before
+ public void beforeTest()
+ {
+ dir = "target/" + APP_ID + "/";
+
+ MockitoAnnotations.initMocks(this);
+ when(mockschedular.scheduleWithFixedDelay(any(Runnable.class),
anyLong(), anyLong(), any(TimeUnit.class)))
+ .thenReturn(futureTaskMock);
+ }
+
+ @After
+ public void afterTest() throws IOException
+ {
+ cleanTable();
+ FileUtils.deleteDirectory(new File(dir));
+ }
+
+ @Test
+ public void testDBPoller() throws InterruptedException
+ {
+ insertEvents(10, true, 0);
+
+ JdbcStore store = new JdbcStore();
+ store.setDatabaseDriver(DB_DRIVER);
+ store.setDatabaseUrl(URL);
+
+ List<FieldInfo> fieldInfos = getFieldInfos();
+
+ Attribute.AttributeMap.DefaultAttributeMap portAttributes = new
Attribute.AttributeMap.DefaultAttributeMap();
+ portAttributes.put(Context.PortContext.TUPLE_CLASS,
TestPOJOEvent.class);
+ TestPortContext tpc = new TestPortContext(portAttributes);
+
+ JdbcPOJOPollInputOperator inputOperator = new
JdbcPOJOPollInputOperator();
+ inputOperator.setStore(store);
+ inputOperator.setTableName(TABLE_POJO_NAME);
+ inputOperator.setKey("id");
+ inputOperator.setFieldInfos(fieldInfos);
+ inputOperator.setFetchSize(100);
+ inputOperator.setBatchSize(100);
+ inputOperator.setPartitionCount(2);
+
+ TestUtils.MockBatchedOperatorStats readerStats = new
TestUtils.MockBatchedOperatorStats(2);
--- End diff --
Is this used?
> Update JDBC poll input operator to fix issues
> ---------------------------------------------
>
> Key: APEXMALHAR-2172
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2172
> Project: Apache Apex Malhar
> Issue Type: Improvement
> Reporter: Priyanka Gugale
> Assignee: Priyanka Gugale
>
> Update JDBCPollInputOperator to:
> 1. Fix small bugs
> 2. Use jooq query dsl library to construct sql queries
> 3. Make code more readable
> 4. Use row counts rather than key column values to partition reads
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
