See comments on PR. On Fri, Aug 26, 2016 at 7:16 AM, Yogi Devendra <[email protected] > wrote:
> Fix for APEXMALHAR-2206 has been reviewed and merged into asf master. > > ~ Yogi > > On 26 August 2016 at 19:04, Yogi Devendra <[email protected]> > wrote: > > > We noticed that lc.runAsync() is called without corresponding > > lc.shutdown() at couple of places in unit tests. > > > > This caused: > > 1. Async thread continuing. > > 2. Build not terminating. > > 3. target dir size incresing indefinately. > > > > @All reviewers > > Please make sure to check for lc.shutdown() for every lc.runAsync(). > > > > ~ Yogi > > > > On 26 August 2016 at 17:07, Bhupesh Chawda <[email protected]> > > wrote: > > > >> Hi Thomas, > >> > >> https://issues.apache.org/jira/browse/APEXMALHAR-2206 is one small bug > >> which Yogi pointed out. It was intermittently taking too long to > complete > >> the travis builds. We thought it would be a good idea to get it in for > the > >> release. > >> > >> I have just opened a PR: https://github.com/apache/apex-malhar/pull/383 > >> > >> ~ Bhupesh > >> > >> > >> On Fri, Aug 26, 2016 at 9:45 AM, Yogi Devendra < > >> [email protected] > >> > wrote: > >> > >> > https://github.com/apache/apex-malhar/pull/372 is open for > >> > APEXMALHAR-2195. > >> > > >> > I have incorporated the review comments from @gauravgopi123, @tweise > >> > I have updated fix version to 3.5.0 to reflect this ticket in the > query. > >> > > >> > Can someone please review and merge this for 3.5.0? > >> > > >> > ~ Yogi > >> > > >> > On 25 August 2016 at 21:41, Chaitanya Chebolu < > >> [email protected]> > >> > wrote: > >> > > >> > > Hi Thomas, > >> > > > >> > > I will fix APEXMALHAR-2134. > >> > > > >> > > Regards, > >> > > Chaitanya > >> > > > >> > > On Thu, Aug 25, 2016 at 9:13 PM, Thomas Weise < > [email protected] > >> > > >> > > wrote: > >> > > > >> > > > We are almost ready to get the RC out. > >> > > > > >> > > > Can someone fix APEXMALHAR-2134 for the release? > >> > > > > >> > > > > >> > > > On Wed, Aug 17, 2016 at 12:56 PM, Thomas Weise < > >> [email protected] > >> > > > >> > > > wrote: > >> > > > > >> > > > > Friendly reminder.. There are still a few unresolved tickets for > >> 3.5: > >> > > > > > >> > > > > https://issues.apache.org/jira/issues/?jql=fixVersion% > >> > > > > 20%3D%203.5.0%20AND%20project%20%3D%20APEXMALHAR%20AND% > >> > > > 20resolution%20%3D% > >> > > > > 20Unresolved%20ORDER%20BY%20priority%20DESC > >> > > > > > >> > > > > Please remove the fix version unless you expect to complete the > >> work > >> > in > >> > > > > the next few days. > >> > > > > > >> > > > > And we need to complete the PR for high level API: > >> > > > > > >> > > > > https://issues.apache.org/jira/browse/APEXMALHAR-2142 > >> > > > > > >> > > > > Thanks, > >> > > > > Thomas > >> > > > > > >> > > > > > >> > > > > On Fri, Aug 5, 2016 at 2:12 AM, Chaitanya Chebolu < > >> > > > > [email protected]> wrote: > >> > > > > > >> > > > >> APEXMALHAR-2100. PR is open: https://github.com/apache/apex > >> > > > >> -malhar/pull/330 > >> > > > >> > >> > > > >> Regards, > >> > > > >> Chaitanya > >> > > > >> > >> > > > >> On Fri, Aug 5, 2016 at 1:10 PM, Priyanka Gugale < > >> > > > [email protected] > >> > > > >> > > >> > > > >> wrote: > >> > > > >> > >> > > > >> > APEXMALHAR-2171 > >> > > > >> > PR is open: https://github.com/apache/apex-malhar/pull/358 > >> > > > >> > > >> > > > >> > -Priyanka > >> > > > >> > > >> > > > >> > On Fri, Aug 5, 2016 at 12:32 PM, Yogi Devendra < > >> > > > >> > [email protected] > >> > > > >> > > wrote: > >> > > > >> > > >> > > > >> > > Fix for APEXMALHAR-2176 > >> > > > >> > > PR open: https://github.com/apache/apex-malhar/pull/361 > >> > > > >> > > > >> > > > >> > > ~ Yogi > >> > > > >> > > > >> > > > >> > > On 1 August 2016 at 11:59, Chinmay Kolhatkar < > >> > > > [email protected] > >> > > > >> > > >> > > > >> > > wrote: > >> > > > >> > > > >> > > > >> > > > APEXMALHAR-2128 is already done. Somehow the status did > >> not go > >> > > to > >> > > > >> > > resolved. > >> > > > >> > > > Changed it now. > >> > > > >> > > > > >> > > > >> > > > On Fri, Jul 29, 2016 at 1:53 PM, Yogi Devendra < > >> > > > >> > > > [email protected] > >> > > > >> > > > > wrote: > >> > > > >> > > > > >> > > > >> > > > > APEXMALHAR-2116 > >> > > > >> > > > > https://github.com/apache/apex-malhar/pull/326 > >> > > > >> > > > > > >> > > > >> > > > > @Ram > >> > > > >> > > > > Your review comments are incorporated. Could you please > >> > have a > >> > > > >> look > >> > > > >> > at > >> > > > >> > > > > this? > >> > > > >> > > > > > >> > > > >> > > > > ~ Yogi > >> > > > >> > > > > > >> > > > >> > > > > On 29 July 2016 at 13:49, Thomas Weise < > >> > > [email protected]> > >> > > > >> > wrote: > >> > > > >> > > > > > >> > > > >> > > > > > Hi, > >> > > > >> > > > > > > >> > > > >> > > > > > I would suggest to target the 3.5.0 release with an > RC > >> out > >> > > > >> perhaps > >> > > > >> > 2 > >> > > > >> > > > > weeks > >> > > > >> > > > > > from now, as there is a good amount of work that we > >> should > >> > > > make > >> > > > >> > > > available > >> > > > >> > > > > > to the users: > >> > > > >> > > > > > > >> > > > >> > > > > > > >> > > > >> > > > > > > >> > > > >> > > > > https://issues.apache.org/jira/browse/APEXMALHAR/ > >> > > > >> > > > fixforversion/12335815/?selectedTab=com.atlassian. > >> > > > >> > > > jira.jira-projects-plugin:version-issues-panel > >> > > > >> > > > > > > >> > > > >> > > > > > I also think that the following should go in: > >> > > > >> > > > > > > >> > > > >> > > > > > https://issues.apache.org/ > jira/browse/APEXMALHAR-2128 > >> > > > >> > > > > > https://issues.apache.org/ > jira/browse/APEXMALHAR-2142 > >> > > > >> > > > > > https://issues.apache.org/ > jira/browse/APEXMALHAR-2063 > >> > > > >> > > > > > > >> > > > >> > > > > > Any other candidates? > >> > > > >> > > > > > > >> > > > >> > > > > > There are quite a few other PRs open: > >> > > > >> > > > > > > >> > > > >> > > > > > https://github.com/apache/apex-malhar/pulls > >> > > > >> > > > > > > >> > > > >> > > > > > Would be good to complete some more reviews for this > >> > > release. > >> > > > >> > > > > > > >> > > > >> > > > > > Thanks, > >> > > > >> > > > > > Thomas > >> > > > >> > > > > > > >> > > > >> > > > > > >> > > > >> > > > > >> > > > >> > > > >> > > > >> > > >> > > > >> > >> > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > > > > >
