[ 
https://issues.apache.org/jira/browse/APEXMALHAR-2267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15527465#comment-15527465
 ] 

ASF GitHub Bot commented on APEXMALHAR-2267:
--------------------------------------------

GitHub user davidyan74 opened a pull request:

    https://github.com/apache/apex-malhar/pull/431

    APEXMALHAR-2267 #resolve renamed spillable data structures to remove the 
word "Byte"

    @siyuanh  please merge

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/davidyan74/apex-malhar APEXMALHAR-2267

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/apex-malhar/pull/431.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #431
    
----
commit f5f1943d2bcc2b61240fab649828c1aaf520d22b
Author: David Yan <[email protected]>
Date:   2016-09-23T19:46:20Z

    APEXMALHAR-2267 #resolve renamed spillable data structures to remove the 
word "Byte"

----


> Remove the word "Byte" in the spillable data structures because it's implied
> ----------------------------------------------------------------------------
>
>                 Key: APEXMALHAR-2267
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2267
>             Project: Apache Apex Malhar
>          Issue Type: Improvement
>            Reporter: David Yan
>            Assignee: David Yan
>
> Spillable means part of the data is on disk and they need to be serialized, 
> and part of the data is in cache as objects. That already means the 
> serialized form (byte array) of the key needs to agree with the equals method 
> on the key object, and no need to add the word "Byte" in all the DS names. 
> Removing the word "Byte" also will remove the confusion caused by names like 
> "SpillableByteArrayListMultimap".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to