[ 
https://issues.apache.org/jira/browse/APEXMALHAR-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15575074#comment-15575074
 ] 

ASF GitHub Bot commented on APEXMALHAR-2299:
--------------------------------------------

GitHub user francisf opened a pull request:

    https://github.com/apache/apex-malhar/pull/454

    APEXMALHAR-2299 Modified to move window when the time reached is grea…

    …ter than or equal to end. The assigner now returns keys without adjusting 
the window for all times >= start and < end. Added a testcase for boundary 
expiry checking
    
    @bhupeshchawda  Please review.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/francisf/apex-malhar 
APEXMALHAR-2299_TimeBasedDedupOperator__Incorrect_key_exception

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/apex-malhar/pull/454.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #454
    
----
commit e14a29fac33d614ba2c97a1ea96b80003d45e465
Author: francisf <francis.fsf...@gmail.com>
Date:   2016-10-14T11:33:15Z

    APEXMALHAR-2299 Modified to move window when the time reached is greater 
than or equal to end. The assigner now returns keys without adjusting the 
window for all times >= start and < end. Added a testcase for boundary expiry 
checking

----


> TimeBasedDedupOperator throws exception during time bucket assignment in 
> certain edge cases
> -------------------------------------------------------------------------------------------
>
>                 Key: APEXMALHAR-2299
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2299
>             Project: Apache Apex Malhar
>          Issue Type: Bug
>    Affects Versions: 3.5.0
>            Reporter: Francis Fernandes
>            Assignee: Francis Fernandes
>             Fix For: 3.6.0
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> The following exception is thrown under certain edge cases:
> {noformat}
> Stopped running due to an exception. java.lang.IllegalArgumentException: new 
> time bucket should have a value greater than the old time bucket
>       at 
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:88)
>       at 
> org.apache.apex.malhar.lib.state.managed.ManagedTimeUnifiedStateImpl.handleBucketConflict(ManagedTimeUnifiedStateImpl.java:126)
>       at 
> org.apache.apex.malhar.lib.state.managed.AbstractManagedStateImpl.prepareBucket(AbstractManagedStateImpl.java:265)
>       at 
> org.apache.apex.malhar.lib.state.managed.AbstractManagedStateImpl.putInBucket(AbstractManagedStateImpl.java:276)
>       at 
> org.apache.apex.malhar.lib.state.managed.ManagedTimeUnifiedStateImpl.put(ManagedTimeUnifiedStateImpl.java:71)
>       at 
> org.apache.apex.malhar.lib.dedup.TimeBasedDedupOperator.putManagedState(TimeBasedDedupOperator.java:191)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to