[
https://issues.apache.org/jira/browse/APEXMALHAR-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15585751#comment-15585751
]
Chandni Singh edited comment on APEXMALHAR-2284 at 10/18/16 3:40 PM:
---------------------------------------------------------------------
One concept that I think I should point is how getAsync improves performance is
that if the value is not available immediately, then the client can cache the
future and work on other keys. Look at the implementations of AbstractDeduper.
1. If SpillableArrayListMultimap only lacks asynchronous get, then that can be
added to it. That should not be the only reason to duplicate the functionality.
2. ManagedTimeMultiValueState has no tests and is full of warnings.
We should not create a complete separate implementation which duplicates a
larger part of functionality provided by something existing otherwise we will
have too many slightly different variations of the same thing and that will be
very difficult to manage.
IMO this is a good opportunity to improve SpillableArrayListMultimapImpl and
use that.
was (Author: csingh):
One concept that I think I should point is that getAsync improves performance
is that if the value is not available immediately, then the client can cache
the future and work on other keys. Look at the implementations of
AbstractDeduper.
1. If SpillableArrayListMultimap only lacks asynchronous get, then that can be
added to it. That should not be the only reason to duplicate the functionality.
2. ManagedTimeMultiValueState has no tests and is full of warnings.
We should not create a complete separate implementation which duplicates a
larger part of functionality provided by something existing otherwise we will
have too many slightly different variations of the same thing and that will be
very difficult to manage.
IMO this is a good opportunity to improve SpillableArrayListMultimapImpl and
use that.
> POJOInnerJoinOperatorTest fails in Travis CI
> --------------------------------------------
>
> Key: APEXMALHAR-2284
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2284
> Project: Apache Apex Malhar
> Issue Type: Bug
> Reporter: Thomas Weise
> Assignee: Chaitanya
> Priority: Blocker
> Fix For: 3.6.0
>
>
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/166322754/log.txt
> {code}
> Failed tests:
> POJOInnerJoinOperatorTest.testEmitMultipleTuplesFromStream2:337 Number of
> tuple emitted expected:<2> but was:<4>
> POJOInnerJoinOperatorTest.testInnerJoinOperator:184 Number of tuple emitted
> expected:<1> but was:<2>
> POJOInnerJoinOperatorTest.testMultipleValues:236 Number of tuple emitted
> expected:<2> but was:<3>
> POJOInnerJoinOperatorTest.testUpdateStream1Values:292 Number of tuple
> emitted expected:<1> but was:<2>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
