Chaitanya commented on APEXMALHAR-2284:

I looked into the PR #434. This uses ManagedTimeUnifiedStateImpl and has the 
implementations of spillable data structure is over BucketedState. 

InnerJoinOperator needs the ManagedTimeStateImpl store which has keyBucket and 
timeBucket as we need the put(keyBucket, timeBucket, Key, Value) call. Here we 
need the TimeSlicedBucketedState where bucketed data is further divided into 
time buckets.

I am planning to remove ManagedTimeStateMultiValue and implement a new 
spillable data structure which use the store as TimeSlicedBucketedState and 
uses ManagedTimeStateImpl.

Does this make sense? Can we go ahead with this plan? 
[~csingh] [~thw] [~bhupesh] Please give your suggestions ?

> POJOInnerJoinOperatorTest fails in Travis CI
> --------------------------------------------
>                 Key: APEXMALHAR-2284
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2284
>             Project: Apache Apex Malhar
>          Issue Type: Bug
>            Reporter: Thomas Weise
>            Assignee: Chaitanya
>            Priority: Blocker
>             Fix For: 3.6.0
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/166322754/log.txt
> {code}
> Failed tests: 
>   POJOInnerJoinOperatorTest.testEmitMultipleTuplesFromStream2:337 Number of 
> tuple emitted  expected:<2> but was:<4>
>   POJOInnerJoinOperatorTest.testInnerJoinOperator:184 Number of tuple emitted 
>  expected:<1> but was:<2>
>   POJOInnerJoinOperatorTest.testMultipleValues:236 Number of tuple emitted  
> expected:<2> but was:<3>
>   POJOInnerJoinOperatorTest.testUpdateStream1Values:292 Number of tuple 
> emitted  expected:<1> but was:<2>
> {code}

This message was sent by Atlassian JIRA

Reply via email to