Hi Hitesh, This is a great idea IMO. Like I mentioned in another thread, the PojoInnerJoin and other MergeAccumulations are only to test the implementation of WindowedMergeOperator. I did not consider many use cases when writing those accumulations, so it will be great if we can handle more types of joins. I personally think the name of the base class you proposed should be PojoJoin because we are only handling streams of Pojos in these accumulations. Thanks, Shuxnin
On Mon, Feb 13, 2017 at 9:50 PM, Hitesh Kapoor <hit...@datatorrent.com> wrote: > Hi All, > > I am proposing PojoOuterJoin accumulation. > We already have PojoInnerJoin accumulation. > > As the name suggests this accumulation will be responsible to get outer > join on Pojo streams > on some input keys. The input and output streams (types) for this > accumulation will be the same > as that of PojoInnerJoin. > > I am planning to create a base class named as Join, > PojoInnerJoin,PojoLeftOuterJoin. > PojoRightOuterJoin,PojoFullOuterJoin can extend the functionalities of > Join > to get the > required join, because there will be a lot of common code in these > accumulations. > > Let me know your thoughts on it. > > Regards, > Hitesh >
