[
https://issues.apache.org/jira/browse/APEXCORE-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15873330#comment-15873330
]
ASF GitHub Bot commented on APEXCORE-624:
-----------------------------------------
GitHub user sanjaypujare opened a pull request:
https://github.com/apache/apex-core/pull/474
APEXCORE-624 decrement unallocated containers and released containers so
exit condition for shutdown check is satisfied.
@vrozov pls review and merge as appropriate. I have also removed
numTotalContainers variable after researching its history and determining that
it is not useful anymore.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sanjaypujare/apex-core
APEXCORE-624.master.sanjay
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/apex-core/pull/474.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #474
----
commit 737f74b184a87c5c059a76d4a619c0a27b71ce9e
Author: Sanjay Pujare <[email protected]>
Date: 2017-02-18T20:33:31Z
APEXCORE-624 decrement unallocated containers and released containers so
exit condition for shutdown check is satisfied.
----
> Shutdown does not work because of incorrect logic in the AppMaster
> ------------------------------------------------------------------
>
> Key: APEXCORE-624
> URL: https://issues.apache.org/jira/browse/APEXCORE-624
> Project: Apache Apex Core
> Issue Type: Bug
> Reporter: Sanjay M Pujare
> Assignee: Sanjay M Pujare
> Priority: Minor
>
> com.datatorrent.stram.StreamingAppMasterService.execute() calculates
> numRequestedContainers incorrectly in some cases (e.g. RM container
> allocation failure) which prevents an application from shutting down when it
> is requested externally. An example is where we ask RM to remove previous
> container allocation request (where the count should be decremented but is
> NOT) and add a new one (where the count should be and IS incremented).
> Another example is the "alreadyAllocated" case where we release the container
> and still increment numRequestedContainers which seems wrong.
> This bug is showing up in multiple Apex deployments.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
