I think the plugins feature could have benefited from better original review, which would have eliminated much of the back and forth after the fact.
On Thu, Apr 27, 2017 at 8:20 AM, Vlad Rozov <v.ro...@datatorrent.com> wrote: > Pramod, > > No, it is not a request to update the apex.apache.org (to do that we need > to file JIRA). It is a reminder that it is against Apex policy to merge PR > without giving enough time for others to review it (few hours after PR was > open). > > Thank you, > > Vlad > > On 4/27/17 08:05, Pramod Immaneni wrote: > >> Vlad, are you asking for a consensus on the policy to make it official >> (publish on website etc). I believe we have one. However, I did not see >> much difference between what you said on Mar 26th to what I proposed on >> Mar >> 24th. Is the main difference any committer can merge (not just the main >> reviewer) as long as there are no objections from others. In that case, I >> am fine with it. >> >> On Thu, Apr 27, 2017 at 7:44 AM, Vlad Rozov <v.ro...@datatorrent.com> >> wrote: >> >> This is a friendly reminder regarding PR merge policy. >>> >>> Thank you, >>> >>> Vlad >>> >>> >>> On 3/23/17 12:58, Vlad Rozov wrote: >>> >>> Lately there were few instances where PR open against apex-core and >>>> apex-malhar were merged just few hours after it being open and JIRA >>>> being >>>> raised without giving chance for other contributors to review and >>>> comment. >>>> I'd suggest that we stop such practice no matter how trivial those >>>> changes >>>> are. This equally applies to documentation. In a rear cases where PR is >>>> urgent (for example one that fixes compilation error), I'd suggest that >>>> a >>>> committer who plans to merge the PR sends an explicit notification to >>>> dev@apex and gives others a reasonable time to respond. >>>> >>>> Thank you, >>>> >>>> Vlad >>>> >>>> >>>> >
