Hi,

> Badly written code, missing and failing unit tests make it harder for 
> everyone to contribute.

IMO having code that can be easily improved makes it easier for people to 
contribute.

> Justin, -1 are infrequent during PR reviews in Apex.

I could easily find 5 from a quick search, which in my experience is unusual, 
but it may be different on other projects. Most projects I’ve been involved in 
almost never have vetos as things are usually sorted out by discussion or 
worked on colatoratively to find a solution before it gets to that point. Can I 
suggest in future rather than casting a veto right away people try and work 
with the person who made the contribution and improve what they have 
contributed.

Thanks,
Justin

Reply via email to