which files are those? -- chetan
On Wed, Sep 23, 2015 at 12:51 PM, Munagala Ramanath <[email protected]> wrote: > Not sure what it's checking but "*mvn license:check*" shows me no list of > files in core. > Yet, my script finds at least 3 java files with no comments at all. > > Ram > > On Wed, Sep 23, 2015 at 11:54 AM, Chetan Narsude <[email protected]> > wrote: > > > mvn license:check > > mvn license:format > > > > At the top level pom does magic for you. > > > > On Wednesday, September 23, 2015, Munagala Ramanath <[email protected] > > > > wrote: > > > > > Thomas and Chris: > > > > > > I wrote a Ruby script to automate this process. Currently, it makes no > > > changes and just > > > reports what it finds. The script is attached. > > > > > > I ran it like this: ruby -w fix-license.rb -f ~/src/apex/apex > > > output.txt > > > The output is also attached. > > > > > > Let me know if you'd like me to enhance this to actually add the new > > > copyright notice to the top of > > > the files where it does detect some form of copyright notice (there > will > > > still be a few files where > > > no such notice was found and those will need manual augmentation). > > > > > > Ram > > > > > > On Tue, Sep 22, 2015 at 9:30 AM, Chris Nauroth < > [email protected] > > > <javascript:_e(%7B%7D,'cvml','[email protected]');>> wrote: > > > > > >> Hi Thomas, > > >> > > >> I think you are correct. Here is the official Apache statement on > what > > to > > >> do with the source headers: > > >> > > >> http://www.apache.org/legal/src-headers.html > > >> > > >> > > >> I think your result (the second example below) matches up with that. > > >> > > >> As a reminder, I have a work-in-progress patch for the non-Java files > in > > >> Apex here: > > >> > > >> https://issues.apache.org/jira/browse/APEXCORE-1 > > >> > > >> > > >> It would be nice if we could come up with a script to chop out the > > >> DataTorrent header and replace it with the ASF header. Then, we could > > >> simply run that across *.java in both Apex and Malhar. > > >> > > >> --Chris Nauroth > > >> > > >> > > >> > > >> > > >> On 9/22/15, 9:24 AM, "Thomas Weise" <[email protected] > > >> <javascript:_e(%7B%7D,'cvml','[email protected]');>> wrote: > > >> > > >> >Hit the wrong button... > > >> > > > >> >This question is about the license header for the source files. > > Currently > > >> >we have: > > >> > > > >> >/** > > >> > * Copyright (C) 2015 DataTorrent, Inc. > > >> > * > > >> > * Licensed under the Apache License, Version 2.0 (the "License"); > > >> > * you may not use this file except in compliance with the License. > > >> > * You may obtain a copy of the License at > > >> > * > > >> > * http://www.apache.org/licenses/LICENSE-2.0 > > >> > * > > >> > * Unless required by applicable law or agreed to in writing, > software > > >> > * distributed under the License is distributed on an "AS IS" BASIS, > > >> > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or > > >> >implied. > > >> > * See the License for the specific language governing permissions > and > > >> > * limitations under the License. > > >> > */ > > >> > > > >> >The first line needs to go. And a reference to NOTICE needs to be > added > > >> as > > >> >shown below? > > >> > > > >> >/* > > >> > * Licensed to the Apache Software Foundation (ASF) under one or more > > >> > * contributor license agreements. See the NOTICE file distributed > > with > > >> > * this work for additional information regarding copyright > ownership. > > >> > * The ASF licenses this file to You under the Apache License, > Version > > >> 2.0 > > >> > * (the "License"); you may not use this file except in compliance > with > > >> > * the License. You may obtain a copy of the License at > > >> > * > > >> > * http://www.apache.org/licenses/LICENSE-2.0 > > >> > * > > >> > * Unless required by applicable law or agreed to in writing, > software > > >> > * distributed under the License is distributed on an "AS IS" BASIS, > > >> > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or > > >> >implied. > > >> > * See the License for the specific language governing permissions > and > > >> > * limitations under the License. > > >> > */ > > >> > > > >> >On Tue, Sep 22, 2015 at 9:19 AM, Thomas Weise < > [email protected] > > >> <javascript:_e(%7B%7D,'cvml','[email protected]');>> > > >> >wrote: > > >> > > > >> >> There > > >> >> > > >> >> > > >> >> > > >> >> > > >> >> > > >> >> > > >> >> > > >> >> > > >> >> > > >> > > >> > > > > > >
