Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/113#discussion_r41945289
--- Diff:
engine/src/main/java/com/datatorrent/stram/StreamingContainerManager.java ---
@@ -1040,15 +1040,31 @@ public int processEvents()
Iterator<Map.Entry<Long, Set<PTOperator>>> it =
shutdownOperators.entrySet().iterator();
while (it.hasNext()) {
Map.Entry<Long, Set<PTOperator>> windowAndOpers = it.next();
- if (windowAndOpers.getKey().longValue() >
this.committedWindowId) {
- // wait until window is committed
- continue;
- } else {
+ if (windowAndOpers.getKey().longValue() <=
this.committedWindowId) {
LOG.info("Removing inactive operators at window {} {}",
Codec.getStringWindowId(windowAndOpers.getKey()), windowAndOpers.getValue());
for (PTOperator oper : windowAndOpers.getValue()) {
plan.removeTerminatedPartition(oper);
}
it.remove();
+ } else {
--- End diff --
Entry is never removed from map. Please do that and plan.remove in a single
place.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
