Github user davidyan74 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/58#discussion_r42021171
  
    --- Diff: contrib/pom.xml ---
    @@ -601,9 +601,9 @@
           <optional>true</optional>
         </dependency>
         <dependency>
    -      <groupId>com.datatorrent</groupId>
    -      <artifactId>dt-common</artifactId>
    -      <version>${dt.framework.version}</version>
    --- End diff --
    
    I think it's better to use apex.core.version instead of just apex.version 
since apex technically includes malhar.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to