GitHub user ilganeli opened a pull request:
https://github.com/apache/incubator-apex-core/pull/117
Refactored monolithic deployInputStream function
In an effort to better understand the flow of data within Apex, I have
refactored the monolithic (200+ line long) deployInputStreams function to
modularize it, add comments, and clarify operational flow.
I would very much appreciate a review to confirm that method and variable
names make sense and that comments appropriately capture what's going on. There
has not been any modification of code (with the exception of duplicate
instantiation of ```streamCodecIdentifier```, ```streamCodec```,
```sinkIdentifer```, and ```sourceIdentifier``` in
```connectInputToBufferServer``` and ```connectInputToLocalSink```. This was
done for the sake of more concise method declaration. All other changes only
involved method extraction.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ilganeli/incubator-apex-core
RefactorDeployInputStreams
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-core/pull/117.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #117
----
commit 11b2fb7de732c928901f862e842a51a58434c556
Author: Ilya Ganelin <[email protected]>
Date: 2015-10-15T16:52:30Z
Refactored monolithic deployInputStream function
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
