I think additional commits from reviews should remain and not be squashed as long as the number of commits is reasonable.
Thanks > On Oct 21, 2015, at 5:42 PM, chandnisingh <[email protected]> wrote: > > Github user chandnisingh commented on the pull request: > > > https://github.com/apache/incubator-apex-core/pull/125#issuecomment-150064224 > > why? the 2 commits address 2 distinct issues then why should we squash > them. Actually if you check other apache projects, it is recommended not to > squash the commits when the change was a result of a review or another issue > which was brought up. > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at [email protected] or file a JIRA ticket > with INFRA. > ---
