GitHub user ilganeli opened a pull request:

    https://github.com/apache/incubator-apex-core/pull/156

    [APEX-230] Set line length to 120

    * Set line length to 120 in CheckStyle. 
    * Removed COMMA from NoWhitespaceBefore check since this was also throwing 
an error. This was broken, and then subsequently fixed in a recent patch of 
CheckStyle but does not appear to have yet been incorporated into the plugin. 
See: https://github.com/checkstyle/checkstyle/issues/2089
    
    * I did not update the actual CodeStyle settings to automatically enforce 
wrapping for longer lines because how we want to do this is a more complex 
question and potentially outside the scope of this issue. For now, CheckStyle 
will simply throw an error if the line is too long.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ilganeli/incubator-apex-core SetLineLength120

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-apex-core/pull/156.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #156
    
----
commit 8742d60cb82b2941378f2980055f29ddd713fcc3
Author: Ilya Ganelin <[email protected]>
Date:   2015-11-04T20:18:49Z

    Set line length to 120 in CheckStyle. Removed COMMA from 
NoWhitespaceBeforeCheck since this was broken in an earlier CheckStyle patch. 
This addresses APEX-230

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to