I don't have any strong opinions about this. If the pull request build fails because of the code style violations then for me that is good enough.
However will wait till tomorrow just to make sure no one has any objections. Chandni On Tue, Nov 10, 2015 at 12:06 AM, Chetan Narsude (cnarsude) < cnars...@cisco.com> wrote: > I remembered I reviewed this and hence I knew whom to ask :-) Probably I > miscommunicated then. All the following can be achieved even if the phase > is kept to default “verify”. So if this is all the history, then it should > be safe to move it to verify. I’ll make that change and send you a pull > request. > > > — > Chetan > > > On 11/9/15, 11:58 PM, "Chandni Singh" <chan...@datatorrent.com> wrote: > > >Chetan, > > > >Please look at your comment on this pull request > >https://github.com/DataTorrent/Apex-old/pull/124 > > > >I am quoting and highlighting what you have commented on the pull > >request: > >"overall it looks good to me. Can you enable it such that only if *more > >deviations are added, the build will fail*? And make it chatty only when a > >system property is specified while building." > > > >The change to run it in validate phase was made after you had asked for > >it. > > > >Thanks, > >Chandni > > > > > >On Mon, Nov 9, 2015 at 11:39 PM, Chetan Narsude <che...@apache.org> > wrote: > > > >> CI has been setup to run the builds all the way to verify phase - which > >>is > >> quality control phase. It is really the minimal phase everybody should > >>run > >> before they make the packaged code available for wider audience. This > >> phase also includes semver checks today. So we should remove the > >> artificial phase binding and let the defaults work. > >> > >> Bringing the code formatting to the the first phase just makes it > >> impossible to do quick revisions often times done in an environment > >>where > >> IDE is unavailable. > >> > >> ‹ > >> Chetan > >> > >> > >> On 11/9/15, 11:19 PM, "Chandni Singh" <chan...@datatorrent.com> wrote: > >> > >> >Because the requirement was to fail the build if any code was added > >>that > >> >breaks a style rule. > >> > > >> >Chandni > >> > > >> >On Mon, Nov 9, 2015 at 11:15 PM, Chetan Narsude <che...@iitbombay.org> > >> >wrote: > >> > > >> >> Chandni - > >> >> > >> >> What's the reason for the check style plugin to be invoked during > >> >>maven's > >> >> validate phase as opposed to verify (the default phase for which the > >> >>plugin > >> >> is written)? > >> >> > >> >> -- > >> >> Chetan > >> >> > >> > >> > >> > >
