Github user brightchen commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/82#discussion_r44825680
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/hive/AbstractFSRollingOutputOperator.java
---
@@ -183,12 +184,7 @@ protected void rotateCall(String lastFile)
try {
this.rotate(lastFile);
}
- catch (IOException ex) {
- logger.debug(ex.getMessage());
- DTThrowable.rethrow(ex);
- }
- catch (ExecutionException ex) {
- logger.debug(ex.getMessage());
+ catch (IOException | ExecutionException ex) {
--- End diff --
The HiveMockTest also has a issue. the fsRolling.setRotationWindows should
be called to set the window.
And the HiveMockTest is using the embed Hive, you in fact can test even if
Hive not installed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
