Github user 243826 commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/173#issuecomment-159417794
Vlad,
512k is undesirable and will cause other problems when exercised (I
discussed those in the email). The kind of code surgery needed with this pull
request is unneeded when we cannot use 512k. The slight performance boost you
claim to get is coming at the cost of losing accuracy of the size() call and
constructs to fix that. I also said that even with 512k, the benchmark itself
is done under ideal (unreal) conditions and will not boil down to much if not
none performance gain.
-
Chetan
From: Vlad Rozov <[email protected]<mailto:[email protected]>>
Reply-To: apache/incubator-apex-core
<[email protected]<mailto:[email protected]>>
Date: Tuesday, November 24, 2015 at 12:40 PM
To: apache/incubator-apex-core
<[email protected]<mailto:[email protected]>>
Cc: Chetan Narsude <[email protected]<mailto:[email protected]>>
Subject: Re: [incubator-apex-core] APEX-254 & APEX-269 (#173)
@243826<https://github.com/243826> Please bring the discussion here, I did
not see anything in the e-mail that will justify -1 to this pull request. The
only thing under question is changing InlineStream default queue size and it is
not part of this pull request.
SpscArrayQueueReservoir outperforms CircularBufferReservoir by 4x with the
queue size set to 512000 and is on par or better with the default queue size.
-
Reply to this email directly or view it on
GitHub<https://github.com/apache/incubator-apex-core/pull/173#issuecomment-159398782>.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
