[
https://issues.apache.org/jira/browse/APEXCORE-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068529#comment-15068529
]
ASF GitHub Bot commented on APEXCORE-291:
-----------------------------------------
Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/190#discussion_r48283776
--- Diff:
engine/src/test/java/com/datatorrent/stram/engine/AutoMetricTest.java ---
@@ -361,6 +384,15 @@ public int getMyMetric()
}
}
+ public static class OperatorAndAggregator extends OperatorWithMetrics
implements AutoMetric.Aggregator
+ {
+ @Override
+ public Map<String, Object> aggregate(long windowId,
Collection<AutoMetric.PhysicalMetricsContext> physicalMetrics)
+ {
+ return null;
--- End diff --
I think this test aggregator method should actually do something, then
verify it in the testDefaultMetricsAggregator method.
> Provide a way for an operator to specify its metric aggregator instance
> -----------------------------------------------------------------------
>
> Key: APEXCORE-291
> URL: https://issues.apache.org/jira/browse/APEXCORE-291
> Project: Apache Apex Core
> Issue Type: Improvement
> Reporter: Chandni Singh
> Assignee: Chandni Singh
>
> Need a way to let an operator to provide its default metrics aggregator
> instance.
> If an operator class implements AutoMetric.Aggregator then use that logical
> instance of the operator class as the default metrics aggregator.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
