Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/137#discussion_r48380423
--- Diff: library/src/main/java/com/datatorrent/lib/parser/Parser.java ---
@@ -47,10 +47,19 @@
* @since 3.2.0
*/
@InterfaceStability.Evolving
-public abstract class Parser<INPUT> extends BaseOperator implements
Converter<INPUT, Object>,
- ActivationListener<Context>
+public abstract class Parser<INPUT> extends BaseOperator implements
Converter<INPUT, Object>
{
protected transient Class<?> clazz;
+ @AutoMetric
+ protected long errorTupleCount;
+ @AutoMetric
+ protected long emittedObjectCount;
+ @AutoMetric
+ protected long rollingPercentValidTuples;
+ @AutoMetric
+ protected long rollingPercentErrorTuples;
+ @AutoMetric
+ protected long incomingTuplesCount;
@OutputPortFieldAnnotation(schemaRequired = true)
--- End diff --
@ishark is correct. If the schemaRequired port is not connected, then
validation will not fail even though the TUPLE_CLASS attribute is missing.
@shubham-pathak22 Schema required annotation is an expressive way to let
the users know that processing of tuples which are received on this port
requires the tuple schema. I will suggest that if you face any limitations or
problems with this feature, then you should take it up on apex dev.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
