Github user tushargosavi commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/191#discussion_r48522048
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -1359,7 +1409,8 @@ private void addDAGToCurrentDAG(ModuleMeta moduleMeta)
String name;
for (OperatorMeta operatorMeta : subDag.getAllOperators()) {
name = subDAGName + MODULE_NAMESPACE_SEPARATOR +
operatorMeta.getName();
- this.addOperator(name, operatorMeta.getOperator());
+ Operator op = this.addOperator(name, operatorMeta.getOperator());
--- End diff --
OperatorMeta has name and id declared as final field. In our case we want
to add the operator to top level dag with expanded name and wants to have a
unique id in the parent DAG. Hence reused the addOperator api without adding a
new one. This has additional cost of allocating new OperatorMeta though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
