[
https://issues.apache.org/jira/browse/APEXCORE-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074077#comment-15074077
]
ASF GitHub Bot commented on APEXCORE-272:
-----------------------------------------
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/191#discussion_r48554311
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
@@ -1359,7 +1409,8 @@ private void addDAGToCurrentDAG(ModuleMeta moduleMeta)
String name;
for (OperatorMeta operatorMeta : subDag.getAllOperators()) {
name = subDAGName + MODULE_NAMESPACE_SEPARATOR +
operatorMeta.getName();
- this.addOperator(name, operatorMeta.getOperator());
+ Operator op = this.addOperator(name, operatorMeta.getOperator());
--- End diff --
@tweise should we drop "final" qualifier from name and id to avoid the
complexity of copying from the original OperatorMeta? If not, I suggest
introducing copy constructor for OperatorMeta that takes original OperatorMeta
as a parameter and encapsulates the copy operation.
> Attributes added to operator inside Module is not preserved.
> ------------------------------------------------------------
>
> Key: APEXCORE-272
> URL: https://issues.apache.org/jira/browse/APEXCORE-272
> Project: Apache Apex Core
> Issue Type: Bug
> Reporter: Tushar Gosavi
> Assignee: Tushar Gosavi
>
> Attributes added to operator within a Module is not preserved.
> for example
> {code}
> class M implements Module {
> public void populateDAG(DAG dag, Configuration conf) {
> DummyOperator o1 = dag.addOperator("O1", new DummyOperator());
> o1.setOperatorProp(level1ModuleProp);
> dag.getMeta(o1).getAttributes().put(Context.OperatorContext.MEMORY_MB,
> 512);
> }
> {code}
> The above code when module is expanded attribute set on operator o1 is lost.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
