[
https://issues.apache.org/jira/browse/APEXCORE-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074765#comment-15074765
]
ASF GitHub Bot commented on APEXCORE-276:
-----------------------------------------
Github user chandnisingh commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/193#issuecomment-167954861
A recommendation is to add a test which sets a custom metrics transport and
see if that gets picked up
> Make App Data Push transport pluggable and configurable
> -------------------------------------------------------
>
> Key: APEXCORE-276
> URL: https://issues.apache.org/jira/browse/APEXCORE-276
> Project: Apache Apex Core
> Issue Type: New Feature
> Reporter: David Yan
> Assignee: David Yan
>
> Currently it's not possible without changing the code to have your own
> transport.
> Code from AppDataPushAgent.java:
> {code}
> public void init()
> {
> String appDataPushTransport =
> dnmgr.getLogicalPlan().getValue(DAGContext.METRICS_TRANSPORT);
> if (appDataPushTransport.startsWith(APP_DATA_PUSH_TRANSPORT_BUILTIN_VALUE
> + ":")) {
> String topic =
> appDataPushTransport.substring(APP_DATA_PUSH_TRANSPORT_BUILTIN_VALUE.length()
> + 1);
> appDataPusher = new WebsocketAppDataPusher(dnmgr.getWsClient(), topic);
> LOG.info("App Data Push Transport set up for {}", appDataPushTransport);
> } else {
> // TBD add kakfa
> LOG.error("App Data Push Transport not recognized: {}",
> appDataPushTransport);
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
