Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/193#discussion_r48619961
--- Diff: api/src/main/java/com/datatorrent/api/Context.java ---
@@ -335,10 +335,16 @@
Attribute<String> APPLICATION_DATA_LINK = new Attribute<String>(new
String2String());
/**
* Transport to push the stats and the metrics, "builtin:{topic}" if
STRAM should push the data directly
- * using websocket with the given topic
+ * using websocket with the given topic.
+ * If using a custom transport, please use Object2String codec to
specify the transport object. The object must
+ * be from a class that implements the AutoMetric.Transport interface
*/
Attribute<String> METRICS_TRANSPORT = new Attribute<String>(new
String2String());
--- End diff --
So what it means here is that we are asking the user to convert the object
to string using Object2String codec before setting this attribute?
Why don't we deprecate this and add another attribute which is of type
Attribute<AutoMetric.Transport> which is consistent with rest of the complex
attributes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
