Github user gauravgopi123 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/185#discussion_r48774037
  
    --- Diff: 
engine/src/main/java/com/datatorrent/stram/engine/GenericNode.java ---
    @@ -394,6 +463,15 @@ else if (tracker.ports[trackerIndex] == activePort) {
                   case END_STREAM:
                     activePort.remove();
                     buffers.remove();
    +                if (firstWindowId == -1) {
    +                  // this is for recovery from a checkpoint for 
DelayOperator
    +                  if (delay) {
    +                    // if it's a DelayOperator and this is the first 
RESET_WINDOW (start) or END_STREAM (recovery),
    +                    // fabricate the first window
    +                    fabricateFirstWindow((Operator.DelayOperator)operator, 
windowAhead);
    +                  }
    +                  firstWindowId = t.getWindowId();
    --- End diff --
    
    Again same Should this firstWindowId not be assigned when delay is true and 
firstWindowId == -1?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to