Wouldn't that mark the JIRA as resolved by the committer as opposed to the contributor. It might be better to have the contributor mark it resolved after the pull request is merged or after final confirmation from committer after the reviews are done that everything is good to go.
On Tue, Jan 5, 2016 at 10:16 AM, Thomas Weise <[email protected]> wrote: > Yes. Earlier that could be done with #resolve, now whoever does the git > push needs to go into JIRA and also push the button there. > > On Tue, Jan 5, 2016 at 10:12 AM, Pramod Immaneni <[email protected]> > wrote: > > > Shouldn't the issue be marked resolved when the change is actually > merged. > > > > On Tue, Jan 5, 2016 at 9:59 AM, Thomas Weise <[email protected]> > > wrote: > > > > > Friendly reminder, part of pushing pull requests is to take care of the > > > associated JIRAs. The ASF system does not support the smart commits, so > > the > > > person pushing the change will need to resolve the issue. Fix version > > needs > > > to be set. > > > > > > > > > http://apex.incubator.apache.org/contributing.html#merging-a-pull-request- > > > committers- > > > < > > > > > > http://apex.incubator.apache.org/contributing.html#merging-a-pull-request-committers- > > > > > > > > > >
