Github user vrozov commented on a diff in the pull request:

    
https://github.com/apache/incubator-apex-malhar/pull/168#discussion_r49598385
  
    --- Diff: samples/pom.xml ---
    @@ -34,6 +34,11 @@
     
       <name>Apache Apex Malhar (incubating) Samples</name>
     
    +  <properties>
    +    <semver.plugin.skip>true</semver.plugin.skip>
    --- End diff --
    
    It depends on the percentage of modules that semver should be enabled and 
disabled for. In Malhar, there are more modules where it needs to be disabled, 
it seems that repeating 
    ```
          <plugin>
            <groupId>com.github.siom79.japicmp</groupId>
            <artifactId>japicmp-maven-plugin</artifactId>
          </plugin>
    ```
    only for modules where semver needs to be enabled will be more applicable 
in this case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to