Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/167#discussion_r49651581
--- Diff:
kafka/src/main/java/org/apache/apex/malhar/kafka/AbstractKafkaPartitioner.java
---
@@ -257,13 +257,13 @@ public boolean equals(Object o)
}
PartitionMeta that = (PartitionMeta)o;
return Objects.equals(cluster, that.cluster) &&
- Objects.equals(topicPartition, that.topicPartition);
+ Objects.equals(getTopicPartition(), that.getTopicPartition());
--- End diff --
instead of comparing topicPartition object, why not compare topic and
partitionId?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
