[ 
https://issues.apache.org/jira/browse/APEXCORE-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116556#comment-15116556
 ] 

ASF GitHub Bot commented on APEXCORE-304:
-----------------------------------------

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/208#discussion_r50790859
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/StramLocalCluster.java 
---
    @@ -318,6 +333,21 @@ public StramLocalCluster(LogicalPlan dag) throws 
IOException, ClassNotFoundExcep
         }
       }
     
    +  private void addExtraJarsToClasspath(Set<String> jars)
    +      throws InvocationTargetException, IllegalAccessException, 
MalformedURLException, NoSuchMethodException
    +  {
    +    List<URL> jarUrls = new LinkedList<>();
    +    for (String jarPath : jars) {
    +      File file = new File(jarPath);
    +      URL url = file.toURI().toURL();
    +      jarUrls.add(url);
    +    }
    +
    +    ClassLoader prevCl = Thread.currentThread().getContextClassLoader();
    +    ClassLoader urlCl = URLClassLoader.newInstance(jarUrls.toArray(new 
URL[jarUrls.size()]), prevCl);
    +    Thread.currentThread().setContextClassLoader(urlCl);
    --- End diff --
    
    I doubt that this provides required functionality as for example 
Class.forName() will not work if it is called from the top level module or 
operator loaded by the system ClassLoader.


> Ability to add jars to classpath in populateDAG
> -----------------------------------------------
>
>                 Key: APEXCORE-304
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-304
>             Project: Apache Apex Core
>          Issue Type: Improvement
>            Reporter: Chinmay Kolhatkar
>            Assignee: Chinmay Kolhatkar
>
> This will have following functionality:
> 1) In populateDAG one would be allowed to add given local jar path to 
> classpath of the application.
> 2) Optionally delete the given jar file after copying to HDFS is done.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to